This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Create autoscale resources for scaleset #1661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevoinea
commented
Feb 17, 2022
| @@ -1,29 +1,9 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
The original file was moved to log_analytics.py
tevoinea
commented
Feb 18, 2022
| retry_on_auth_failure, | ||
| ) | ||
|
|
||
| # TODO: Look into deleting auto scale resource when deleting scaleset |
There was a problem hiding this comment.
Tested this locally using onefuzz scalesets shutdown. Azure automatically deletes the auto scale resource so we don't need to add any additional logic for that case.
tevoinea
commented
Feb 18, 2022
| @@ -0,0 +1,29 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
tevoinea
commented
Feb 18, 2022
| params: Dict[str, Any] = { | ||
| "location": location, | ||
| "profiles": [profile], | ||
| "target_resource_uri": scaleset_uri, |
There was a problem hiding this comment.
When it comes time to enable autoscale by default, we just need to add:
"enabled": True,
chkeita
approved these changes
Feb 24, 2022
stishkin
approved these changes
Feb 24, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
This PR creates an auto scale resource for scalesets that uses the pool work queue as the tirgger metric.
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?
.properties.profiles.properties.enabled == false