This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Handle instance being destroyed before updating scaling protection #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stishkin
approved these changes
Mar 21, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
Handles a new exception when attempting to update scaling protection on a VMSS instance.
PR Checklist
Info on Pull Request
What does this include?
There are 2 new cases that are handled:
In 1, we're OK with the exception because we had no expectation of the node continuing to live anyway.
In 2, we propagate the error.
Validation Steps Performed
I intentionally triggered the exception by trying to update an instance that I know doesn't exist.