This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
handle nested exceptions during cleanup on function deploy failures #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 18, 2020 01:41
…to run func command
…to run func command
…to run func command
bmc-msft
changed the title
bmc-msft
approved these changes
Oct 19, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
If subprocess.check_output() raises an exception, the handler for TemporaryDirectory() attempts to delete tmpdirname. This causes a permissions error since the terminal's cwd has been changed to tmpdirname. I'm not sure if this happens on Linux but on Windows, another exception is throw along with the error returned by check_output().
PR Checklist
Info on Pull Request
This fix removes the need to use os.chdir().
Validation Steps Performed
I tested this fix using Windows but not Linux.