Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

C# Refactor For Webhook Queue #1818

Merged
merged 35 commits into from
Apr 26, 2022
Merged

C# Refactor For Webhook Queue #1818

merged 35 commits into from
Apr 26, 2022

Conversation

nharper285
Copy link
Contributor

Summary of the Pull Request

What is this about?

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@nharper285 nharper285 marked this pull request as draft April 20, 2022 17:28
@nharper285 nharper285 marked this pull request as ready for review April 22, 2022 00:18
@tevoinea
Copy link
Member

There's an empty file src/ApiService/ApiService/OneFuzzTypes/Primitives.cs

tevoinea
tevoinea approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@tevoinea tevoinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 small things to check but nothing blocking!

src/ApiService/ApiService/onefuzzlib/WebhookOperations.cs Outdated Show resolved Hide resolved
src/ApiService/ApiService/onefuzzlib/WebhookOperations.cs Show resolved Hide resolved
@nharper285 nharper285 merged commit 0b1c7ae into microsoft:main Apr 26, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tevoinea tevoinea tevoinea approved these changes

@stishkin stishkin stishkin approved these changes

@chkeita chkeita chkeita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nharper285 @tevoinea @chkeita @stishkin