-
Notifications
You must be signed in to change notification settings - Fork 198
Conversation
- Deployment script checks the roles on the deployed application and update them if necessary
fix app role update query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deploy.py uses CLIError
to catch errors from add_application_password
, which comes from azure-cli-core, which was removed as a prerequisite.
I'm guessing errors in add_application_password
are no longer raised CLI errors and we should catch a different exception here, rather than re-adding azure-cli-core
but I'm unsure of what that would be.
onefuzz/src/deployment/deploy.py
Line 20 in 2e5d3e0
from azure.cli.core import CLIError |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing failed using clean venv:
Traceback (most recent call last):
File "deploy.py", line 36, in <module>
from azure.mgmt.applicationinsights import ApplicationInsightsManagementClient
ModuleNotFoundError: No module named 'azure.mgmt.applicationinsights'
Apparently, this module was pulled in via one of the prereq libraries that this PR removes.
In a fresh venv, this gives the following errors:
|
|
restoring azure-cli and azure-cli-core getting the token from cli-profile
Testing latest update |
Summary of the Pull Request
Allows the nodes in the scaleset to access the service by assigning their managed identity to the ManagedNode Role
PR Checklist
Info on Pull Request
What does this include?
Validation Steps Performed