Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Allow ignoring directories #1931

Merged
merged 5 commits into from
May 12, 2022
Merged

Conversation

tevoinea
Copy link
Member

Summary of the Pull Request

What is this about?

Allow the DirectoryMonitor to skip reporting directories. The default behavior is to continue reporting them so we don't change the behavior unexpectedly.

PR Checklist

  • Closes DirectoryMonitor reports creation of both files and directories #1856
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

Tested with the dir-monitor example.

Copy link
Member

@ranweiler ranweiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just a few comments!

Also, can we add some unit tests?

src/agent/onefuzz/src/monitor.rs Outdated Show resolved Hide resolved
src/agent/onefuzz/src/monitor.rs Outdated Show resolved Hide resolved
@ranweiler ranweiler changed the title Allow ingoring directories Allow ignoring directories May 11, 2022
@tevoinea tevoinea requested a review from ranweiler May 12, 2022 14:21
@tevoinea tevoinea enabled auto-merge (squash) May 12, 2022 19:36
@tevoinea tevoinea merged commit 8fbe049 into main May 12, 2022
@tevoinea tevoinea deleted the tevoinea/AllowOptionallReportingDirectories branch May 16, 2022 10:39
@ghost ghost locked as resolved and limited conversation to collaborators Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DirectoryMonitor reports creation of both files and directories
2 participants