-
Notifications
You must be signed in to change notification settings - Fork 198
Add timestamp to agent log #1972
Add timestamp to agent log #1972
Conversation
Adding the timestamp directly in the message might be redundant with app insight since everything gets a timestamp there. If the goal is to have it in the written logs we might want to format the message in the task logger instead |
Any chance we don't write stuff to AppInisghts from the Agent ? Maybe only errors ? And the rest of the logs are kept in files ? There is so much noise in App Inisghts right now, is it required ? |
We definitely could start removing stuff from AI after this change makes it in. I would propose moving traces to log file only and keep events and errors in AI as a first step. I'll create an issue |
Summary of the Pull Request
What is this about?
Adds timestamp to agent tracing log output.
PR Checklist
Info on Pull Request
What does this include?
LogEvent
->LoggingEvent
LogTrace
andLogEvent
structs to organize necessary logging info https://github.com/microsoft/onefuzz/pull/1972/files#diff-52c53d4179505ba0dd3f46e2707afeb66f5208e6138b52159fd48134af41a73fR340-R356Validation Steps Performed
How does someone test & validate?
Ran check-pr, checked the blob logs and the AI logs.