Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Add timestamp to agent log #1972

Merged
merged 14 commits into from
May 26, 2022

Conversation

tevoinea
Copy link
Member

@tevoinea tevoinea commented May 24, 2022

Summary of the Pull Request

What is this about?

Adds timestamp to agent tracing log output.

PR Checklist

  • Applies to work item: Add timestamps to agent logs #1939
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

Ran check-pr, checked the blob logs and the AI logs.

@chkeita chkeita self-requested a review May 24, 2022 22:25
@chkeita
Copy link
Contributor

chkeita commented May 24, 2022

Adding the timestamp directly in the message might be redundant with app insight since everything gets a timestamp there. If the goal is to have it in the written logs we might want to format the message in the task logger instead

@stishkin
Copy link
Contributor

Any chance we don't write stuff to AppInisghts from the Agent ? Maybe only errors ? And the rest of the logs are kept in files ?

There is so much noise in App Inisghts right now, is it required ?

@tevoinea
Copy link
Member Author

Any chance we don't write stuff to AppInisghts from the Agent ? Maybe only errors ? And the rest of the logs are kept in files ?

There is so much noise in App Inisghts right now, is it required ?

We definitely could start removing stuff from AI after this change makes it in. I would propose moving traces to log file only and keep events and errors in AI as a first step. I'll create an issue

@tevoinea tevoinea enabled auto-merge (squash) May 26, 2022 11:55
@tevoinea tevoinea merged commit 7fde79e into microsoft:main May 26, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants