This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Properly compare job/task state enums in JobHelper.check_current_job()
#2004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
JobHelper.check_current_job()
currently always reports a successful status because it compares state enums with string literals, which will never succeed (confusingly).In addition, by default
self.onefuzz.tasks.list
will only list active tasks (excluding ones that are in a shutting down state).PR Checklist
Info on Pull Request
This simply removes string literal comparisons in favor of lists returned by the state object itself.
Validation Steps Performed
Unsure - I don't know if there's any commands that can easily be ran to check this functionality.
This should be a simple enough code review.