This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Update appinsights to released version
#2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
changed the title
appinsights to released version
Porges
force-pushed
the
appinsights-rs-released
branch
from
67a1304 to
83f56ff
Compare
Porges
commented
Jun 9, 2022
tevoinea
reviewed
Jun 9, 2022
tevoinea
approved these changes
Jun 9, 2022
Porges
force-pushed
the
appinsights-rs-released
branch
2 times, most recently
from
0053c1a to
f37cfe2
Compare
|
Validating with |
Porges
force-pushed
the
appinsights-rs-released
branch
3 times, most recently
from
522b766 to
ee4ade9
Compare
Porges
force-pushed
the
appinsights-rs-released
branch
from
ee4ade9 to
e3452dd
Compare
Merged
AdamL-Microsoft
added a commit
to AdamL-Microsoft/onefuzz
that referenced
this pull request
Jun 27, 2022
Porges
added a commit
that referenced
this pull request
Jun 27, 2022
#2033 appears to be breaking agent since we are getting nested tokio runtimes. Revert it!
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that there was a note to update
appinsightsto a released version once one was available, and now one is.The
closefunction was changed to beasyncin the latest version, sotry_flush_and_closemust also become async. Luckily, the three places we use this already have an async context available.PR Checklist
Applies to work item: #xxxRequires documentation to be updatedI've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxxValidation Steps Performed
Standard test run.