This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Implement the node C# function
#2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
force-pushed
the
function/node
branch
3 times, most recently
from
f3a257a to
b16ddaa
Compare
Porges
commented
Jun 22, 2022
tevoinea
reviewed
Jun 22, 2022
tevoinea
reviewed
Jun 22, 2022
tevoinea
approved these changes
Jun 22, 2022
Porges
force-pushed
the
function/node
branch
2 times, most recently
from
4b95ff1 to
f7ba54a
Compare
stishkin
approved these changes
Jun 22, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
nodefunction from Python to C#.PoolNamefor consistency with Python version.PR Checklist
nodeto C# #2068Requires documentation to be updatedI've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxxInfo on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?