Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Scaleset/autoscale cli default min size to zero #2112

Conversation

AdamL-Microsoft
Copy link
Contributor

@AdamL-Microsoft AdamL-Microsoft commented Jul 1, 2022

Summary of the Pull Request

> onefuzz scalesets create $NAME --image $IMAGE --region $REGION
# now accepts & implies the following:
> onefuzz scalesets create $NAME --image $IMAGE --region $REGION --min_instances 0

Allows setting the scaleset + autoscale minimum instances count to zero at creation time and also sets zero as the onefuzz scaleset create command default if --min_instances argument isn't specified.

PR Checklist

Info on Pull Request

updated:
src/cli/onefuzz/api.py
src/pytypes/onefuzztypes/requests.py

@Porges
Copy link
Member

Porges commented Jul 12, 2022

Closes #2144.

@AdamL-Microsoft AdamL-Microsoft marked this pull request as ready for review July 13, 2022 00:09
@AdamL-Microsoft AdamL-Microsoft merged commit d71c558 into microsoft:main Jul 13, 2022
@AdamL-Microsoft AdamL-Microsoft deleted the autoscale-cli-default-min-size-to-zero branch July 13, 2022 15:59
@ghost ghost locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When we create scalesets the minimum number of VM's should be set to zero.
4 participants