This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Make the log sas url last as long as the job duration #2116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stishkin
reviewed
Jul 1, 2022
stishkin
approved these changes
Jul 1, 2022
mgreisen
approved these changes
Jul 1, 2022
stishkin
approved these changes
Jul 1, 2022
chkeita
added a commit
to chkeita/onefuzz
that referenced
this pull request
Jul 2, 2022
tevoinea
added
the
refactor-diverge
chkeita
added a commit
to chkeita/onefuzz
that referenced
this pull request
Jul 5, 2022
Make the log sas url last as long as the job duration
chkeita
added a commit
that referenced
this pull request
Jul 5, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixes an issue where the job logs sas token could expire before the job was scheduled