Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Drop the global event sender on close #2125

Merged
merged 7 commits into from
Jul 14, 2022
Merged

Drop the global event sender on close #2125

merged 7 commits into from
Jul 14, 2022
+75 −79

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented Jul 5, 2022 •
edited
Loading

  • Changed the logic of closing the logger to rely on the close channel message to stop the logging process.
  • Rename flush field to done
  • Increased the timeout when closing the logger

closes #2011

@chkeita chkeita force-pushed the bug_fix branch 3 times, most recently from 3a0d76a to 9d71d64 Compare July 11, 2022 16:17
@chkeita chkeita marked this pull request as ready for review July 11, 2022 20:20
@chkeita chkeita enabled auto-merge (squash) July 14, 2022 00:46
@chkeita chkeita merged commit fe8b750 into microsoft:main Jul 14, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tevoinea tevoinea tevoinea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flush log files in the agent before exiting the task
2 participants
@chkeita @tevoinea