Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Add extensions functionality for C# refactor #2218

Merged

Conversation

tevoinea
Copy link
Member

@tevoinea tevoinea commented Aug 4, 2022

Summary of the Pull Request

What is this about?

Related to migrating timer_repro.

Highlights of changes:

  • Added ImageOperations which is used for working with VM images.
  • Made generic wrapper type over VirtualMachineScaleSetExtensionData and VirtualMachineExtensionData. We use the same extensions (and same extension properties) for both and since I can't add a shared interface between the types ( and instead of duplicating the extension configuration functions), I created VMExtensionWrapper.
  • Fixed some bugs in the existing extensions functions (ex: making sure our types are serialized as Azure expects, a couple of missing awaits)

PR Checklist

@tevoinea tevoinea merged commit 3a0e8bb into microsoft:main Aug 4, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants