This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
disable sympath in libfuzzer_coverage extraction unless it's set via target_env #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmc-msft
commented
Oct 28, 2020
| @@ -83,7 +83,14 @@ function processModule(module, results_dir) { | |||
| return true; | |||
| } | |||
|
|
|||
| function dumpCounters(results_dir, sample_name) { | |||
There was a problem hiding this comment.
Note, sample_name was not provided by any of the users of this script and was only used to pass to a function that didn't have it as an argument.
lzybkr
approved these changes
Oct 28, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Disables sympath used in cdb unless it's explicitly set via target_env. This significantly improves the runtime performance of sancov extraction.
Validation Steps Performed
Ran with
onefuzz-agent.exe debug libfuzzer-coverage, once with--target_env _NT_SYMBOL_PATH=c:\symbolsand once without. Note that without is significantly faster.Follow on work
libfuzzer_coverageto support variable expansion appropriate.{setup_dir}such that the setup dir can be explicitly set.