Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Make log sinks a singleton #2247

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

tevoinea
Copy link
Member

Summary of the Pull Request

What is this about?

This should fix our OOM Exceptions caused by initializing telemetry for every function invocation.

PR Checklist

Info on Pull Request

What does this include?

  • Makes the log sinks singletons
  • LogTracer remains scoped since it has "single threaded only" functions (ReplaceCorrelationId, AddTags)

Validation Steps Performed

How does someone test & validate?

  1. Run .net functions locally
  2. Validate telemetry is showing up in App Insights in a dev instance.

@tevoinea tevoinea marked this pull request as ready for review August 12, 2022 15:27
@Porges Porges force-pushed the tevoinea/MakeTelemetrySingleton branch from 92f2eab to 1fe5950 Compare August 15, 2022 04:18
@tevoinea tevoinea enabled auto-merge (squash) August 15, 2022 13:37
@tevoinea tevoinea merged commit ef0367c into microsoft:main Aug 15, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants