Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Autoscale Table Synces Current Scaleset Settings #2255

Merged
merged 36 commits into from
Aug 17, 2022
Merged

Autoscale Table Synces Current Scaleset Settings #2255

merged 36 commits into from
Aug 17, 2022

Conversation

nharper285
Copy link
Contributor

@nharper285 nharper285 commented Aug 15, 2022 •
edited
Loading

Summary of the Pull Request

What is this about?
Currently, AutoScale table entries are not synced with the current state of the VMSS for a OneFuzz instance. This includes config updates and deletes.

#2041

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

nharper285 and others added 30 commits August 15, 2022 12:10
@nharper285
Autoscale Table Syncs Current Scaleset Settings.
3e519db
@nharper285
Merge branch 'main' into user/noharper/autoscale-auto-sync
b8c9efa
@nharper285
Merge branch 'main' into user/noharper/autoscale-auto-sync
822ff70
@nharper285
Fixing formatting.
89e4fe0
@nharper285
Merge branch 'user/noharper/autoscale-auto-sync' of https://github.co…
2b0405e 
…m/nharper285/onefuzz into user/noharper/autoscale-auto-sync
@nharper285
Fixing lint.
acefea7
@nharper285
Remove white space.
4f2eb82
@nharper285
Adding default check.
46203da
@nharper285
Formatting.
f0c32c8
@nharper285
Fix.
f0883fb
@nharper285
Fixing import.
b7088a3
@nharper285
Fixing ref.
c79fdbc
@nharper285
Trying regular save.
6cee1ea
@nharper285
using self.
86bab79
@nharper285
Trying to fix lint.
1ee67b6
@nharper285
Fixing args.
470ee4e
@nharper285
Fixed.
8b4704f
@nharper285
Adding function call.
2796282
@nharper285
Reformat.
d42dd90
@nharper285
Formatting.
a77ec46
@nharper285
trying again.
16574f0
@nharper285
Merge branch 'main' into user/noharper/autoscale-auto-sync
ddc07a7
@nharper285
FIxing profile call.
d0896a5
@nharper285
Fixing type.
b9a5ee9
@nharper285
Fixing type.
12e6745
@nharper285
Fixing format.
73b74ee
@nharper285
Fixing typing.
9a52014
@nharper285
Fixing.
1081090
@nharper285
Fixing function call
e947047
@nharper285
Getting rid of length check.
10fe5b5
@nharper285 nharper285 requested a review from tevoinea August 16, 2022 23:45
@nharper285 nharper285 marked this pull request as ready for review August 16, 2022 23:48
tevoinea
tevoinea approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@tevoinea tevoinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to port to C# or mark with refactor-diverge

@nharper285 nharper285 added the refactor-diverge Used to indicate that python code - that has already been refactored - has been updated. label Aug 17, 2022
@nharper285 nharper285 merged commit fdd16df into microsoft:main Aug 17, 2022
@nharper285 nharper285 mentioned this pull request Sep 13, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mgreisen mgreisen mgreisen left review comments

@tevoinea tevoinea tevoinea approved these changes

Assignees
No one assigned
Labels
refactor-diverge Used to indicate that python code - that has already been refactored - has been updated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nharper285 @mgreisen @tevoinea