This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Enforce that there no extra properties in request JSON, and that non-null properties are [Required] #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
force-pushed
the
enforce-no-extra-properties
branch
from
e25de4c to
da00fdb
Compare
Porges
commented
Aug 31, 2022
Porges
changed the title
tevoinea
approved these changes
Aug 31, 2022
|
We should be sure to let this change bake a little longer than usual because it has the potential to expose a lot of small serialization bugs we missed. |
Porges
force-pushed
the
enforce-no-extra-properties
branch
from
da00fdb to
cb6abec
Compare
Porges
changed the title
Porges
force-pushed
the
enforce-no-extra-properties
branch
2 times, most recently
from
ac99710 to
2e2c0e2
Compare
|
Found an issue already in |
Porges
force-pushed
the
enforce-no-extra-properties
branch
from
2e2c0e2 to
16d7b27
Compare
|
Found during testing that the CLI does send |
tevoinea
approved these changes
Sep 1, 2022
Porges
force-pushed
the
enforce-no-extra-properties
branch
2 times, most recently
from
f0b286e to
db6c955
Compare
Porges
force-pushed
the
enforce-no-extra-properties
branch
from
bfe535b to
d893241
Compare
|
Passed |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2314 via two fixes, one for additional properties and one for missing properties:
BaseRequestwhich has anExtensionDataproperty, and ensure that it is empty inParseRequest.[Required]attribute to non-nullable properties that do not have defaults, and add a test that ensures we have this attribute where necessary.