This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Remove the max_elapsed_time limit from az_copy #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code still relies on the number of retry to limit the requests
stishkin
approved these changes
Aug 31, 2022
Porges
approved these changes
Aug 31, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with az_copy syncing. The failure were caused by the fact that the files were being modified while the we were syncing them.
However, The retry mechanism that should have allowed us to attempt the copy again was not triggered because the syncing operation is taking too long (more than 15 min which was the default max elapsed time).
This PR remove the
max_elapsed_timelimit and only relies on the RETRY_COUNT to limit the number of attempts at syncing.closes #2160