Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Tests for scaleset size validation #243

Merged
merged 8 commits into from
Nov 3, 2020
Merged

Tests for scaleset size validation #243

merged 8 commits into from
Nov 3, 2020

Conversation

anshuman-goel
Copy link
Contributor

@anshuman-goel anshuman-goel commented Nov 2, 2020 •
edited
Loading

Summary of the Pull Request

Adding test for the change #156 for scaleset size validation

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

@anshuman-goel anshuman-goel changed the title scaleset size Test for scaleset size validation Nov 2, 2020
@anshuman-goel anshuman-goel changed the title Test for scaleset size validation Tests for scaleset size validation Nov 2, 2020
@anshuman-goel anshuman-goel marked this pull request as ready for review November 2, 2020 16:52
@anshuman-goel anshuman-goel mentioned this pull request Nov 2, 2020
Merged
5 tasks
bmc-msft
bmc-msft suggested changes Nov 2, 2020
View reviewed changes
src/pytypes/tests/test_models.py Outdated Show resolved Hide resolved
@bmc-msft bmc-msft merged commit 46064fb into microsoft:main Nov 3, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmc-msft bmc-msft bmc-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshuman-goel @bmc-msft