Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Adding New Default Image Config Value to IC. #2434

Merged
merged 19 commits into from
Sep 23, 2022

Conversation

nharper285
Copy link
Contributor

@nharper285 nharper285 commented Sep 21, 2022

Summary of the Pull Request

What is this about?
We currently have default image value for linux and windows VMSS and VMs hard-coded into OneFuzz. When they need to be updated, we have to submit a PR. This change adds the value to our InstanceConfig.

PR Checklist

  • Applies to work item: Create Instance Config Property for Default VMSS/VM Images #2229
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

  • Check-PR [Python]
  • Check-PR [C#]
  • Python - Manual verify scaleset default create works for Windows VMSS
  • Python - Manual verify scaleset default create works for Linux VMSS
  • Python - Manual verify scaleset create works with --image flag for Windows VMSS
  • Python - Manual verify scaleset create works with --image flag for Linux VMSS
  • Python - Manual verify scaleset create work with different instance_config Windows Image value
  • Python - Manual verify scaleset create works with different instance_config Linux Image value
  • Python - Manual verify proxy create work with instance_config Windows Image value
  • Python - Manual verify proxy create works with instance_config Linux Image value
  • Python - Manual verify repro create work with instance_config Windows Image value
  • Python - Manual verify repro create works with instance_config Linux Image value
  • C# - Manual verify scaleset default create works for Windows VMSS
  • C# - Manual verify scaleset default create works for Linux VMSS
  • C# - Manual verify scaleset create works with --image flag for Windows VMSS
  • C# - Manual verify scaleset create works with --image flag for Linux VMSS
  • C# - Manual verify scaleset create work with different instance_config Windows Image value
  • C# - Manual verify scaleset create works with different instance_config Linux Image value
  • C#- Manual verify proxy create work with instance_config Windows Image value
  • C# - Manual verify proxy create works with instance_config Linux Image value
  • C# - Manual verify repro create work with instance_config Windows Image value
  • C# - Manual verify repro create works with instance_config Linux Image value

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2022

Codecov Report

Merging #2434 (5f04b76) into main (de766df) will increase coverage by 2.60%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2434      +/-   ##
==========================================
+ Coverage   29.85%   32.45%   +2.60%     
==========================================
  Files         289      170     -119     
  Lines       35083    23110   -11973     
==========================================
- Hits        10475     7501    -2974     
+ Misses      24608    15609    -8999     
Impacted Files Coverage Δ
src/ApiService/ApiService/Functions/Scaleset.cs
src/ApiService/ApiService/OneFuzzTypes/Model.cs
src/ApiService/ApiService/OneFuzzTypes/Requests.cs
src/ApiService/ApiService/UserCredentials.cs
src/ApiService/ApiService/Functions/TimerRepro.cs
src/ApiService/ApiService/Functions/Webhooks.cs
...ApiService/ApiService/onefuzzlib/OnefuzzContext.cs
...Service/ApiService/onefuzzlib/WebhookOperations.cs
src/ApiService/ApiService/Functions/WebhookLogs.cs
.../ApiService/ApiService/onefuzzlib/JobOperations.cs
... and 109 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nharper285 nharper285 marked this pull request as ready for review September 22, 2022 16:40
@nharper285 nharper285 merged commit 3f35d81 into microsoft:main Sep 23, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants