This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Adding New Default Image Config Value to IC. #2434
Merged
nharper285
merged 19 commits into
microsoft:main
from
nharper285:user/noharper/ic-default-image
Sep 23, 2022
Merged
Adding New Default Image Config Value to IC. #2434
nharper285
merged 19 commits into
microsoft:main
from
nharper285:user/noharper/ic-default-image
Sep 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
reviewed
Sep 21, 2022
Porges
reviewed
Sep 21, 2022
Porges
approved these changes
Sep 21, 2022
…harper285/onefuzz into user/noharper/ic-default-image
stishkin
approved these changes
Sep 22, 2022
tevoinea
approved these changes
Sep 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
We currently have default image value for linux and windows VMSS and VMs hard-coded into OneFuzz. When they need to be updated, we have to submit a PR. This change adds the value to our InstanceConfig.
PR Checklist
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?
--image
flag for Windows VMSS--image
flag for Linux VMSS--image
flag for Windows VMSS--image
flag for Linux VMSS