This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Convert ADO traces to customEvents and update notificationInfo
#2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2508 +/- ##
==========================================
- Coverage 29.96% 29.96% -0.01%
==========================================
Files 289 289
Lines 35421 35424 +3
==========================================
Hits 10615 10615
- Misses 24806 24809 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nharper285
changed the title
traces to events and update notificationInfo
nharper285
changed the title
traces to events and update notificationInfotraces to customEvents and update notificationInfo
mgreisen
reviewed
Oct 13, 2022
* Update the logic update the scaleinProtection * build fix
* Add SrcView::try_insert function * Make try_insert return bool indicating success * Rustfmt * Set test to be ignored (no compile) * Bump srcview version Co-authored-by: Sutton Bradley <suttonb@microsoft.com> Co-authored-by: George Pollard <gpollard@microsoft.com>
nharper285
force-pushed
the
user/noharper/notification-job-details
branch
from
4502f38 to
e49a9ef
Compare
stishkin
reviewed
Oct 13, 2022
tevoinea
reviewed
Oct 13, 2022
tevoinea
reviewed
Oct 13, 2022
stishkin
reviewed
Oct 13, 2022
tevoinea
approved these changes
Oct 13, 2022
stishkin
approved these changes
Oct 13, 2022
…ub.com/nharper285/onefuzz into user/noharper/notification-job-details
tevoinea
approved these changes
Oct 13, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
Adding project and name to ADO notifications.
PR Checklist
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?