This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Reduce number of ARM calls in ListVmss #2539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
force-pushed
the
reduce-arm-calls
branch
from
2831d57 to
1e2ee69
Compare
Codecov Report
@@ Coverage Diff @@
## main #2539 +/- ##
==========================================
+ Coverage 29.82% 29.83% +0.01%
==========================================
Files 289 289
Lines 35750 35738 -12
==========================================
Hits 10664 10664
+ Misses 25086 25074 -12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tevoinea
approved these changes
Oct 20, 2022
chkeita
approved these changes
Oct 20, 2022
Porges
force-pushed
the
reduce-arm-calls
branch
2 times, most recently
from
ca5baa4 to
f2c7960
Compare
chkeita
reviewed
Oct 26, 2022
Porges
force-pushed
the
reduce-arm-calls
branch
3 times, most recently
from
8a7b7cd to
8092f9e
Compare
This reverts commit 546e073.
Porges
force-pushed
the
reduce-arm-calls
branch
from
8092f9e to
4ca8c4d
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ListVmsswas invokingGetVirtualMachineScaleSetAsyncand thenGetVirtualMachineScaleSetVms; instead we can get the VMSS resource directly and invokeGetVirtualMachineScaleSetVmson it.I also removed some unneeded invocations of
AsAsyncEnumerablewhich might be turning async enumerables into sync enumerables.Do the same
HasDatacheck in the instance ID lookup that we were already doing inListVmss.After this change (#3) we no longer do any
GETs against individual VMSS VMs during thecheck-prrun: