This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Exponential backoff for failed notifications #2555
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
#2553
Today, our file-changes-poison queue does not get consumed and we manually re-queue those messages. This PR automatically re-processes those messages using an exponential backoff. The backoff times are:
Once a message hits the 1 week backoff point (or 6 attempts), we log a warning (though we should consider adding a webhook as well).
Info on Pull Request
What does this include?
file-changes-poison
queuefailTaskOnTransientError
toisLastRetryAttempt
to more accurately reflect the behavior of that flag (it was changed in a previous PR)Validation Steps Performed
How does someone test & validate?