This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Include computer name in AgentRegistration & decode Instance ID from it #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2557 +/- ##
==========================================
- Coverage 35.52% 29.83% -5.70%
==========================================
Files 134 289 +155
Lines 17123 35747 +18624
==========================================
+ Hits 6083 10664 +4581
- Misses 11040 25083 +14043
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Yes, we will have to have different handling for them. If they send |
Porges
force-pushed
the
include-instance-id
branch
from
October 25, 2022 00:37
9f17cad
to
e77734a
Compare
Porges
changed the title
Include computer name in AgentRegistration
Include computer name in AgentRegistration & decode Instance ID from it
Oct 25, 2022
Porges
force-pushed
the
include-instance-id
branch
from
October 25, 2022 01:01
dc66f18
to
e6f0f40
Compare
chkeita
reviewed
Oct 25, 2022
chkeita
approved these changes
Oct 25, 2022
Porges
force-pushed
the
include-instance-id
branch
from
October 26, 2022 00:11
c9d67ae
to
487907e
Compare
tevoinea
approved these changes
Oct 26, 2022
chkeita
approved these changes
Oct 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #2550 but in a slightly different way: