Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Reduce fetches to VMSS #2577

Merged
merged 7 commits into from
Oct 28, 2022
Merged

Reduce fetches to VMSS #2577

merged 7 commits into from
Oct 28, 2022

Conversation

Porges
Copy link
Member

@Porges Porges commented Oct 27, 2022

Remove another GET from ListInstanceIds, and only invoke ListInstanceIds if we have to (i.e. one of the nodes is missing InstanceId).

@Porges Porges changed the title Reduce fetches in vmss Reduce fetches to VMSS Oct 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

Merging #2577 (58b77f3) into main (4b305d0) will decrease coverage by 5.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2577      +/-   ##
==========================================
- Coverage   29.89%   24.79%   -5.10%     
==========================================
  Files         289      120     -169     
  Lines       35767    12486   -23281     
==========================================
- Hits        10692     3096    -7596     
+ Misses      25075     9390   -15685     
Impacted Files Coverage Δ
...ce/ApiService/TestHooks/NodeOperationsTestHooks.cs 0.00% <0.00%> (ø)
...ApiService/ApiService/onefuzzlib/NodeOperations.cs 23.31% <0.00%> (-0.35%) ⬇️
...ervice/ApiService/onefuzzlib/ScalesetOperations.cs 2.67% <0.00%> (+<0.01%) ⬆️
...ApiService/ApiService/onefuzzlib/VmssOperations.cs 0.00% <0.00%> (ø)
src/agent/coverage/src/cobertura.rs
...rc/agent/onefuzz-task/src/tasks/fuzz/supervisor.rs
...c/agent/onefuzz-task/src/local/generic_analysis.rs
src/agent/onefuzz-agent/src/reboot/double.rs
src/agent/srcview/src/pdbcache.rs
... and 164 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Porges Porges force-pushed the reduce-fetches-in-vmss branch from 949b21f to 4abe9f5 Compare October 28, 2022 01:28
@Porges Porges requested a review from tevoinea October 28, 2022 02:24
@chkeita chkeita enabled auto-merge (squash) October 28, 2022 19:39
@chkeita chkeita merged commit 3626589 into main Oct 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Nov 28, 2022
@chkeita chkeita deleted the reduce-fetches-in-vmss branch December 2, 2022 22:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants