This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
commented
Oct 27, 2022
Porges
commented
Oct 27, 2022
Codecov Report
@@ Coverage Diff @@
## main #2577 +/- ##
==========================================
- Coverage 29.89% 24.79% -5.10%
==========================================
Files 289 120 -169
Lines 35767 12486 -23281
==========================================
- Hits 10692 3096 -7596
+ Misses 25075 9390 -15685
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chkeita
reviewed
Oct 28, 2022
chkeita
reviewed
Oct 28, 2022
Porges
force-pushed
the
reduce-fetches-in-vmss
branch
from
October 28, 2022 01:28
949b21f
to
4abe9f5
Compare
chkeita
approved these changes
Oct 28, 2022
tevoinea
reviewed
Oct 28, 2022
tevoinea
approved these changes
Oct 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove another
GET
fromListInstanceIds
, and only invokeListInstanceIds
if we have to (i.e. one of the nodes is missingInstanceId
).