This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Delete nodes on decommission instead of just releasing scale in protection #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevoinea
commented
Oct 31, 2022
stishkin
approved these changes
Oct 31, 2022
chkeita
approved these changes
Oct 31, 2022
Porges
approved these changes
Oct 31, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
We want to discard nodes as soon as they're done completing their assigned tasks. This is different from the current behavior where we try to re-use nodes by reimaging them. Originally, this discard process was accomplished by removing scale-in protection and letting auto scale take care of everything. The issue with that approach is that scale-in actions only happen when the work queue for the pool is empty so letting auto scale delete the nodes won't work for a system under load.
This PR changes our approach to deleting nodes right away instead of reimaging or waiting for scale-in actions. The behavior continues to be behind the "NodeDisposalStrategies" env var until we decide to enable it by default.