Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Make Proxy TelemetryKey optional #2619

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Make Proxy TelemetryKey optional #2619

merged 2 commits into from
Nov 14, 2022

Conversation

Porges
Copy link
Member

@Porges Porges commented Nov 14, 2022

This is already optional on the Rust side (see: microsoft_telemetry_key). Make it optional on the C# side as well.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2022

Codecov Report

Merging #2619 (76cf74e) into main (0b19af3) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #2619      +/-   ##
==========================================
- Coverage   29.37%   29.37%   -0.01%     
==========================================
  Files         290      290              
  Lines       35597    35596       -1     
==========================================
- Hits        10456    10455       -1     
  Misses      25141    25141              
Impacted Files Coverage Δ
...piService/ApiService/onefuzzlib/ProxyOperations.cs 0.00% <0.00%> (ø)
src/ApiService/ApiService/OneFuzzTypes/Model.cs 72.01% <100.00%> (-0.04%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Porges Porges enabled auto-merge (squash) November 14, 2022 03:10
@Porges Porges merged commit b4750ae into main Nov 14, 2022
@nharper285 nharper285 mentioned this pull request Nov 28, 2022
@Porges Porges deleted the telemetry-optional branch December 8, 2022 21:45
@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants