-
Notifications
You must be signed in to change notification settings - Fork 199
Conversation
resource featureFlags 'Microsoft.AppConfiguration/configurationStores@2022-05-01' = { | ||
name: appConfigName | ||
location: location | ||
sku:{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use managed identity instead of connection strings
App Configuration Data Reader which has GUID: 516239f1-63e1-4d78-a4de-a74fb236a071
resource featureFlags 'Microsoft.AppConfiguration/configurationStores@2022-05-01' = { | ||
name: appConfigName | ||
location: location | ||
sku:{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resource func 'Microsoft.Web/sites@2021-03-01' existing = {
name:
}
var readerRoleId = '516239f1-63e1-4d78-a4de-a74fb236a071'
resource assignReaderRole 'Microsoft.Authorization/roleAssignments@2022-04-01' = {
name: guid('${func.identity.principalId}-role-assignment-reader')
scope: featureFlags
properties: {
principalId: func.identity.principalId
roleDefinitionId: subscriptionResourceId('Microsoft.Authorization/roleDefinitions', readerRoleId)
}
}
Deploying new azure resource just to store one value.... seems like too much ? |
Codecov Report
@@ Coverage Diff @@
## main #2620 +/- ##
==========================================
- Coverage 29.29% 29.28% -0.01%
==========================================
Files 289 289
Lines 35755 35765 +10
==========================================
Hits 10474 10474
- Misses 25281 25291 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
So far, I only added the one value to demonstrate how it would be used. This should be the way we do feature management going forward and also in a follow up PR I'm going to add the node dismissal strategy |
Co-authored-by: George Pollard <porges@porg.es>
Summary of the Pull Request
What is this about?
Adds a new App Configuration resource to the onefuzz deploy.
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?
Ran check-pr