This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Fix SignalR client code not reading responses correctly #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2626 +/- ##
=======================================
Coverage 29.37% 29.37%
=======================================
Files 290 290
Lines 35596 35596
=======================================
Hits 10455 10455
Misses 25141 25141 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mgreisen
approved these changes
Nov 15, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Responseobject must have the JSON loaded viajson()(backend.requestwas updated but this callsite was missed).Also, import the
Onefuzztype so that this is type-checked to avoid the same problem in future.