This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Remove Python App Function Deployment Code and enable_dotnet Code.
#2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2636 +/- ##
=======================================
Coverage 29.37% 29.37%
=======================================
Files 290 290
Lines 35603 35603
=======================================
Hits 10457 10457
Misses 25146 25146
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Porges
reviewed
Nov 20, 2022
mgreisen
reviewed
Nov 21, 2022
mgreisen
reviewed
Nov 21, 2022
…per285/onefuzz into user/noharper/deploy-update
mgreisen
reviewed
Nov 21, 2022
chkeita
reviewed
Nov 21, 2022
Porges
reviewed
Nov 22, 2022
Co-authored-by: George Pollard <porges@porg.es>
Porges
reviewed
Nov 22, 2022
| params: { | ||
| server_farm_name: (enable_remote_debugging) ? '${name}-net' : name | ||
| owner: owner | ||
| location: location | ||
| use_windows: enable_remote_debugging |
There was a problem hiding this comment.
I think we decided that we should switch to Windows by default? We will need to test how the upgrade works though, it might require deleting/recreating the App Service Plan (serverFarm)
There was a problem hiding this comment.
Can we leave this change be made at a later time?
There was a problem hiding this comment.
It might be easier from a deployment perspective to keep the changes relegated to what's completely necessary.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
This PR removes Python App Function deployment code and
enable_dotnetcode. It is the first of several PRs that will remove references to the old python app service.For now, we are still deploying two app functions, but they will both be dotnet functions. Any code that can be shared (in
deploy.pyor in any of the*.bicepfiles) is now shared and old python-specific references and resources have been removed.This PR also updates the names of the zips output in the release artifacts. The dotnet api zip is now
api-service.zip, i.e. the primary zip.PR Checklist
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?