Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Making machine identity a parameter of the agent config #2649

Merged
merged 4 commits into from
Nov 24, 2022

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented Nov 22, 2022

Summary of the Pull Request

This is part of the unmanaged node work

This PR introduces MachineIdentity as new configuration field to the agent and the tasks.
It contains the machine_name, machine_id and scaleset name.
When setting this field on the agent, we bypass the current behavior of reading those values from files or the environment.
This allows multiple instances of the agent on the same machine to behave as different nodes.

The existing behavior stays the same when the MachineIdentity is not specified in the config

closes #2521

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #2649 (9d1dbb3) into main (ae827b2) will decrease coverage by 4.45%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2649      +/-   ##
==========================================
- Coverage   29.37%   24.91%   -4.46%     
==========================================
  Files         290      121     -169     
  Lines       35603    12536   -23067     
==========================================
- Hits        10457     3123    -7334     
+ Misses      25146     9413   -15733     
Impacted Files Coverage Δ
src/agent/onefuzz-agent/src/agent.rs
src/agent/onefuzz-agent/src/commands.rs
src/agent/onefuzz-agent/src/config.rs
src/agent/onefuzz-agent/src/heartbeat.rs
src/agent/onefuzz-agent/src/main.rs
src/agent/onefuzz-agent/src/scheduler.rs
src/agent/onefuzz-agent/src/worker.rs
...ent/onefuzz-task/src/local/libfuzzer_test_input.rs
src/agent/onefuzz-task/src/local/test_input.rs
src/agent/onefuzz-task/src/managed/cmd.rs
... and 159 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chkeita chkeita force-pushed the unmanaged_nodes/machine_identity branch 2 times, most recently from 8e5e3bc to 07f8ad6 Compare November 22, 2022 21:04
@chkeita chkeita changed the title making machine identity a parameter Making machine identity a parameter of the agent config Nov 22, 2022
@chkeita chkeita force-pushed the unmanaged_nodes/machine_identity branch from 07f8ad6 to 2a394bf Compare November 22, 2022 21:40
@chkeita chkeita force-pushed the unmanaged_nodes/machine_identity branch from 2a394bf to be6092e Compare November 22, 2022 21:51
@chkeita chkeita marked this pull request as ready for review November 22, 2022 22:27
@chkeita chkeita merged commit 6c981f6 into microsoft:main Nov 24, 2022
@nharper285 nharper285 mentioned this pull request Nov 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change How the agent detect it is running unmanaged
4 participants