This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per285/onefuzz into user/noharper/deploy-update
…per285/onefuzz into user/noharper/deploy-update
Co-authored-by: George Pollard <porges@porg.es>
Codecov Report
@@ Coverage Diff @@
## main #2650 +/- ##
=======================================
Coverage 29.26% 29.26%
=======================================
Files 290 290
Lines 35685 35685
=======================================
Hits 10444 10444
Misses 25241 25241
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nharper285
requested review from
Porges,
AdamL-Microsoft and
stishkin
and removed request for
Porges and
AdamL-Microsoft
November 23, 2022 23:21
chkeita
approved these changes
Nov 23, 2022
mgreisen
reviewed
Nov 23, 2022
mgreisen
reviewed
Nov 23, 2022
mgreisen
approved these changes
Nov 23, 2022
AdamL-Microsoft
approved these changes
Nov 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
This PR removes Python App Function deployment code and
enable_dotnet
code. It is the first of several PRs that will remove references to the old python app service.For now, we are still deploying two app functions, but they will both be dotnet functions. Any code that can be shared (in
deploy.py
or in any of the*.bicep
files) is now shared and old python-specific references and resources have been removed.This PR also updates the names of the zips output in the release artifacts. The dotnet api zip is now
api-service.zip
, i.e. the primary zip.PR Checklist
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?