Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Deploy update #2650

Merged
merged 41 commits into from
Nov 24, 2022
Merged

Deploy update #2650

merged 41 commits into from
Nov 24, 2022

Conversation

nharper285
Copy link
Contributor

@nharper285 nharper285 commented Nov 22, 2022

Summary of the Pull Request

What is this about?
This PR removes Python App Function deployment code and enable_dotnet code. It is the first of several PRs that will remove references to the old python app service.

For now, we are still deploying two app functions, but they will both be dotnet functions. Any code that can be shared (in deploy.py or in any of the *.bicep files) is now shared and old python-specific references and resources have been removed.

This PR also updates the names of the zips output in the release artifacts. The dotnet api zip is now api-service.zip, i.e. the primary zip.

PR Checklist

  • Applies to work item: Update Deployment Code to deploy two dotnet functions #2635
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #2650 (7e97927) into main (6c981f6) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #2650   +/-   ##
=======================================
  Coverage   29.26%   29.26%           
=======================================
  Files         290      290           
  Lines       35685    35685           
=======================================
  Hits        10444    10444           
  Misses      25241    25241           
Impacted Files Coverage Δ
src/ApiService/ApiService/onefuzzlib/Creds.cs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nharper285 nharper285 marked this pull request as ready for review November 23, 2022 23:21
@nharper285 nharper285 requested review from Porges, AdamL-Microsoft and stishkin and removed request for Porges and AdamL-Microsoft November 23, 2022 23:21
@nharper285 nharper285 merged commit e0634a3 into main Nov 24, 2022
@nharper285 nharper285 mentioned this pull request Nov 28, 2022
@Porges Porges deleted the deploy-update branch December 8, 2022 21:45
@ghost ghost locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants