This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Removing Remaining App Function References from Deployment Code. #2682
Merged
nharper285
merged 19 commits into
microsoft:main
from
nharper285:user/noharper/remove-net-func
Dec 16, 2022
Merged
Removing Remaining App Function References from Deployment Code. #2682
nharper285
merged 19 commits into
microsoft:main
from
nharper285:user/noharper/remove-net-func
Dec 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2682 +/- ##
==========================================
+ Coverage 28.64% 29.60% +0.96%
==========================================
Files 308 272 -36
Lines 37662 31416 -6246
==========================================
- Hits 10787 9302 -1485
+ Misses 26875 22114 -4761
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mgreisen
reviewed
Dec 9, 2022
mgreisen
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AdamL-Microsoft
approved these changes
Dec 9, 2022
Co-authored-by: Adam <103067949+AdamL-Microsoft@users.noreply.github.com>
…arper285/onefuzz into user/noharper/remove-net-func
ghost
locked as resolved and limited conversation to collaborators
Jan 15, 2023
closes #2676 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
Removing remaining
-net
references in deployment and agent code.PR Checklist
-net
App Function Deployment Code #2676Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?