Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Adding Public Identifier to Events. #2705

Merged
merged 3 commits into from
Dec 15, 2022

Conversation

nharper285
Copy link
Contributor

Summary of the Pull Request

What is this about?

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

Merging #2705 (8843fed) into main (abcfa4f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2705   +/-   ##
=======================================
  Coverage   28.81%   28.81%           
=======================================
  Files         299      299           
  Lines       36893    36893           
=======================================
  Hits        10632    10632           
  Misses      26261    26261           
Impacted Files Coverage Δ
src/ApiService/ApiService/OneFuzzTypes/Events.cs 82.44% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nharper285 nharper285 marked this pull request as ready for review December 15, 2022 22:11
@mgreisen
Copy link
Contributor

public record JobTaskStopped(

Do we need the [EventType()] attribute?


Refers to: src/ApiService/ApiService/OneFuzzTypes/Events.cs:132 in 8843fed. [](commit_id = 8843fed, deletion_comment = False)

@nharper285
Copy link
Contributor Author

public record JobTaskStopped(

Do we need the [EventType()] attribute?

Refers to: src/ApiService/ApiService/OneFuzzTypes/Events.cs:132 in 8843fed. [](commit_id = 8843fed, deletion_comment = False)

On reflection, the answer is no - this record is used as a type by another event TaskStopped. It's not meant to be an event.

@nharper285 nharper285 merged commit 054910e into microsoft:main Dec 15, 2022
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jan 5, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants