Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Use FF to get node disposal strategy #2713

Merged

Conversation

tevoinea
Copy link
Member

@tevoinea tevoinea commented Dec 19, 2022

Summary of the Pull Request

What is this about?

Use the new App Configuration service to set the node disposal strategy.

This is not a breaking change because each deploy would reset the NodeDisposalStrategy value to scale_in. For this new version, the behavior will be the same (reset to scale_in) but going forward, the state will persist across deploys.

Info on Pull Request

What does this include?

  • Remove loading NodeDisposalStrategy from azure functions configuration.
  • Load NodeDisposalStrategy from App Configuration instead.

@codecov-commenter
Copy link

Codecov Report

Merging #2713 (5e4083a) into main (4c1adb6) will increase coverage by 0.64%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2713      +/-   ##
==========================================
+ Coverage   29.36%   30.00%   +0.64%     
==========================================
  Files         291      196      -95     
  Lines       36202    25136   -11066     
==========================================
- Hits        10631     7543    -3088     
+ Misses      25571    17593    -7978     
Impacted Files Coverage Δ
src/agent/onefuzz/src/auth.rs 30.17% <0.00%> (-0.37%) ⬇️
src/agent/onefuzz-agent/src/config.rs 0.00% <0.00%> (ø)
src/ApiService/ApiService/ServiceConfiguration.cs
...ervice/ApiService/onefuzzlib/ScalesetOperations.cs
...Service/ApiService/onefuzzlib/WebhookOperations.cs
src/ApiService/ApiService/onefuzzlib/Subnet.cs
...Service/ApiService/Functions/QueueSignalREvents.cs
src/ApiService/ApiService/onefuzzlib/Containers.cs
...ice/ApiService/TestHooks/NsgOperationsTestHooks.cs
src/ApiService/ApiService/Functions/Download.cs
... and 144 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tevoinea tevoinea enabled auto-merge (squash) December 21, 2022 14:32
@tevoinea tevoinea merged commit a1060c1 into microsoft:main Dec 21, 2022
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jan 5, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants