Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Add key for block coverage, tests #2715

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

ranweiler
Copy link
Member

Add a blocks subkey to the binary block coverage JSON schema, and test conversions. This will make it easier to add new per-module metadata in the future, if needed.

Old:

{
    "/setup/main.exe": {
        "1": 0,
        "12c": 1,
        "1388": 0
    },
    "/setup/lib/some.dll": {
        "7b": 0,
        "1c8": 10
    }
}

New:

{
    "/setup/main.exe": {
        "blocks": {
            "1": 0,
            "12c": 1,
            "1388": 0
        }
    },
    "/setup/lib/some.dll": {
        "blocks": {
            "7b": 0,
            "1c8": 10
        }
    }
}

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Merging #2715 (be454a6) into main (1726bed) will increase coverage by 0.13%.
The diff coverage is 46.15%.

@@            Coverage Diff             @@
##             main    #2715      +/-   ##
==========================================
+ Coverage   28.44%   28.57%   +0.13%     
==========================================
  Files         319      319              
  Lines       38023    38026       +3     
==========================================
+ Hits        10815    10866      +51     
+ Misses      27208    27160      -48     
Impacted Files Coverage Δ
...gent/onefuzz-file-format/src/coverage/binary/v1.rs 51.85% <36.36%> (+51.85%) ⬆️
src/agent/coverage/src/binary.rs 5.55% <100.00%> (+5.55%) ⬆️
src/agent/debuggable-module/src/lib.rs 7.14% <0.00%> (+3.57%) ⬆️
src/agent/debuggable-module/src/path.rs 20.33% <0.00%> (+20.33%) ⬆️
...gent/onefuzz-file-format/src/coverage/binary/v0.rs 51.61% <0.00%> (+41.93%) ⬆️
src/agent/onefuzz-file-format/src/hex.rs 53.33% <0.00%> (+53.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ranweiler ranweiler merged commit f7bd508 into microsoft:main Dec 20, 2022
@ranweiler ranweiler deleted the block-coverage-key branch December 20, 2022 23:01
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jan 5, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants