This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Config Refactor Round 2. #2771
Merged
nharper285
merged 36 commits into
microsoft:main
from
nharper285:user/noharper/config-endpoint-update-2
Jan 31, 2023
Merged
Config Refactor Round 2. #2771
nharper285
merged 36 commits into
microsoft:main
from
nharper285:user/noharper/config-endpoint-update-2
Jan 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2771 +/- ##
==========================================
- Coverage 29.16% 29.14% -0.02%
==========================================
Files 321 322 +1
Lines 38583 38607 +24
==========================================
Hits 11252 11252
- Misses 27331 27355 +24
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…ub.com/nharper285/onefuzz into user/noharper/config-endpoint-update-2
stishkin
reviewed
Jan 25, 2023
stishkin
reviewed
Jan 25, 2023
stishkin
reviewed
Jan 25, 2023
stishkin
reviewed
Jan 25, 2023
stishkin
reviewed
Jan 25, 2023
stishkin
approved these changes
Jan 25, 2023
mgreisen
reviewed
Jan 25, 2023
mgreisen
reviewed
Jan 25, 2023
mgreisen
reviewed
Jan 25, 2023
Porges
approved these changes
Jan 27, 2023
mgreisen
reviewed
Jan 27, 2023
…ub.com/nharper285/onefuzz into user/noharper/config-endpoint-update-2
chkeita
approved these changes
Jan 31, 2023
mgreisen
reviewed
Jan 31, 2023
Co-authored-by: Marc Greisen <mgreisen@microsoft.com>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
Currently, a number of parameters and arguments must be specified when a user configures their endpoint to an instance.
ex.
onefuzz config --endpoint https://[endpoint].azurewebsites.net/ --authority https://login.microsoftonline.com/72f988bf-86f1-41af-91ab-2d7cd011db47 --client_id 72f1562a-8c0c-41ea-beb9-fa2b71c80134
These parameters -
authority
,client_id
,tenant_domain
, etc. - are used to authenticate to the instance when a user runs a CLI command. They are stored on the local machine, as well.Proposal
Refactor the CLI config command such that it does not require these parameters and only asks the user to specify the
endpoint
. Instead, store the additional config params on the instance - to be set at deployment time - and pull them down every time a user makes a request.PR Checklist
Config
function for retrieving endpoint params. #2774, Update CLI to useConfig
function for auth and get rid of old endpoint config params #2775Validation Steps Performed
How does someone test & validate?