This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 198
Capture crash dumps from libfuzzer, when provided #2793
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2793 +/- ##
==========================================
- Coverage 34.34% 34.23% -0.11%
==========================================
Files 297 297
Lines 36250 36366 +116
==========================================
+ Hits 12450 12451 +1
- Misses 23800 23915 +115
|
chkeita
reviewed
Feb 3, 2023
Porges
changed the title
[draft] Capture crash dumps from libfuzzer, when provided
Capture crash dumps from libfuzzer, when provided
Jul 12, 2023
tevoinea
reviewed
Aug 2, 2023
tevoinea
reviewed
Aug 2, 2023
tevoinea
approved these changes
Aug 2, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables capturing crashdumps generated by ASAN at point of failure.
This helps in several ways:
Crash dumps are automatically collected (for libfuzzer) jobs, if we find any. They should be activated by enabling crash dumps in ASAN, via:
ASAN_OPTIONS=disable_coredump=0:abort_on_error=1:unmap_shadow_on_exit=1
ASAN_SAVE_DUMPS=my_dump.dmp
*.dmp
files in the working directory and then upload them.In both cases, the crash dump will be renamed to match the crashing input, if possible, and uploaded to a new
crashdumps
container.Also updated: the “simple” LibFuzzer test has been updated to be compiled with
cl.exe
instead ofclang
on Windows, so that we are exercising the MSVC implementation of ASAN/LibFuzzer, and the CI image has been updated towindows-2022
. The restriction to an old version of the Windows SDK has been removed.