Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

[Breaking Change] Deploy with scriban only turned on #2809

Merged
merged 3 commits into from
Feb 14, 2023

Conversation

tevoinea
Copy link
Member

@tevoinea tevoinea commented Feb 7, 2023

Summary of the Pull Request

What is this about?

Closes #2767

Updates our bicep template to enable ScribanOnly feature flag. This will enforce that notification templates are only rendered with scriban.

Info on Pull Request

What does this include?

  • Better logging on feature flag state
  • Updates to bicep template to enable ScribanOnly feature flag at deploy time

Validation Steps Performed

How does someone test & validate?

Deploying this PR should create a new ScribanOnly feature flag in App Configuration (if it didn't already exist) and set the flag to enabled (if it wasn't already set to enabled).

@tevoinea tevoinea enabled auto-merge (squash) February 14, 2023 13:15
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Merging #2809 (79dff70) into main (0bc22a8) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2809      +/-   ##
==========================================
- Coverage   29.93%   29.93%   -0.01%     
==========================================
  Files         324      324              
  Lines       38991    38994       +3     
==========================================
  Hits        11671    11671              
- Misses      27320    27323       +3     
Impacted Files Coverage Δ
...ApiService/ApiService/Functions/ValidateScriban.cs 0.00% <0.00%> (ø)
...Service/ApiService/onefuzzlib/notifications/Ado.cs 0.00% <0.00%> (ø)
...piService/onefuzzlib/notifications/GithubIssues.cs 0.00% <0.00%> (ø)
...vice/onefuzzlib/notifications/NotificationsBase.cs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tevoinea tevoinea merged commit 307526f into microsoft:main Feb 14, 2023
@mgreisen mgreisen mentioned this pull request Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforce scriban templates only
3 participants