This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 198
Resolving bug in config refactor. #2811
Merged
nharper285
merged 13 commits into
microsoft:main
from
nharper285:user/noharper/config-refactor-fix
Feb 8, 2023
Merged
Resolving bug in config refactor. #2811
nharper285
merged 13 commits into
microsoft:main
from
nharper285:user/noharper/config-refactor-fix
Feb 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2811 +/- ##
=======================================
Coverage 29.93% 29.93%
=======================================
Files 324 324
Lines 38990 38990
=======================================
Hits 11671 11671
Misses 27319 27319 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chkeita
reviewed
Feb 7, 2023
chkeita
approved these changes
Feb 7, 2023
nharper285
commented
Feb 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
A bug was introduced with the recent config refactor.
list
commands were not working properly. Resolving with this PR.PR Checklist
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?