This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Fix {target_harness} expansion in template
#2866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Porges
changed the title
{target_harness} expansion in template
Codecov Report
@@ Coverage Diff @@
## main #2866 +/- ##
=======================================
Coverage 28.09% 28.09%
=======================================
Files 302 302
Lines 35629 35629
=======================================
Hits 10011 10011
Misses 25618 25618 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chkeita
approved these changes
Feb 20, 2023
|
This is a real bug, but it only lingered because that template has been superseded by what we currently call Since a major release is coming up, now would be a great time to just remove the old POC implementation entirely. PR for that here: #2875 |
|
Closing in favour of #2875 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to have been inadvertently broken by 41f9731.
The missing variable expansion was exposed by #2789, so tasks using
{target_harness}(which is not a valid expansion) fail.