Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Add additional filter check for reports and regressions #2911

Merged

Conversation

nharper285
Copy link
Contributor

Summary of the Pull Request

What is this about?
Add additional filter condition to catch source-coverage.json files.

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

Merging #2911 (f1f8e5c) into main (8a7a0b0) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #2911      +/-   ##
==========================================
- Coverage   28.06%   28.06%   -0.01%     
==========================================
  Files         302      302              
  Lines       35811    35816       +5     
==========================================
  Hits        10050    10050              
- Misses      25761    25766       +5     
Impacted Files Coverage Δ
src/ApiService/ApiService/onefuzzlib/Reports.cs 64.44% <50.00%> (ø)
src/ApiService/ApiService/OneFuzzTypes/Model.cs 69.35% <0.00%> (-0.09%) ⬇️
src/ApiService/ApiService/onefuzzlib/Defs.cs 0.00% <0.00%> (ø)
src/ApiService/ApiService/onefuzzlib/Config.cs 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Porges
Copy link
Member

Porges commented Mar 7, 2023

We should also be able to write a test for this using the existing implementations we have for the Azurite emulator... let me know if you want any help putting one together.

@nharper285 nharper285 merged commit e5dc787 into microsoft:main Mar 7, 2023
@mgreisen mgreisen mentioned this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants