Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Fix notification validation #2914

Merged

Conversation

tevoinea
Copy link
Member

@tevoinea tevoinea commented Mar 7, 2023

Summary of the Pull Request

What is this about?

We were only including the required properties when attempting to render a template for validation purposes. But, templates can still use optional properties so this PR adds the optional properties that were missing to the template render context.

Validation Steps Performed

How does someone test & validate?

  • Added an integration test with an example optional property that was originally missing. {{ report.input_blob.container }}

@tevoinea tevoinea enabled auto-merge (squash) March 7, 2023 20:19
@tevoinea tevoinea merged commit f00248f into microsoft:main Mar 7, 2023
@mgreisen mgreisen mentioned this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants