This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Deployment fix for --auto_create_cli_app flag bug
#2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleted after merge from origin/main
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
TEST
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Codecov Report
@@ Coverage Diff @@
## main #2921 +/- ##
=======================================
Coverage 28.84% 28.84%
=======================================
Files 302 302
Lines 35895 35895
=======================================
Hits 10353 10353
Misses 25542 25542 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
nharper285
reviewed
Mar 10, 2023
There was a problem hiding this comment.
This looks good.
Have you tested in PME and microsoft tenant?
The test cases I would think about are:
- Deploying to Microsoft using the Micrsoft onefuzz-cli app id in
config.json - Using the
auto_createflag to create a cli app id in Microsot tenant - Deploying to PME using the PME onefuzz-cli app id in
config.json - Using the `auto_create flag to create a cli app id in PME tenant.
Co-authored-by: Noah McGregor Harper <74685766+nharper285@users.noreply.github.com>
These tests completed successfully, details in teams. |
nharper285
approved these changes
Mar 10, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fixes #2915.
Refactoring the deployment config and OneFuzz cli config settings created a bug that required new deployments know the CLI app ID prior to it being created in situations where the CLI app ID is specifically set to be created at deploy time using the
--auto_create_cli_appflag.PR Checklist
Info on Pull Request
updated:
src/deployment/deploy.py
src/deployment/deploylib/configuration.py
Validation Steps Performed
deploy.py $REGION $RESOURCE_GROUP $APP_NAME $OWNER config.json --auto_create_cli_app(where config.json doesn't have the normally required "cli_client_id" key)