Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Loosen scriban validation #2963

Merged
merged 10 commits into from
Apr 4, 2023

Conversation

tevoinea
Copy link
Member

@tevoinea tevoinea commented Apr 4, 2023

Summary of the Pull Request

What is this about?

When strict template validation is enabled, we enforce that keys used in the template must exist in TemplateRenderContext's dictionaries in order to pass validation. However, this causes an issue with our validation because we can't know every possible key that could go in the dictionary.

This PR loosens the rule that the keys used in the template must exist in the render context.

Info on Pull Request

What does this include?

  • Loosen the rule
  • Test to validate the change -- in the test, task.tags.project does not exist in the template render context, and the validation is still successful

@codecov-commenter
Copy link

Codecov Report

Merging #2963 (c718a4e) into main (34b513e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2963   +/-   ##
=======================================
  Coverage   29.07%   29.07%           
=======================================
  Files         304      304           
  Lines       36335    36335           
=======================================
  Hits        10566    10566           
  Misses      25769    25769           
Impacted Files Coverage Δ
...vice/onefuzzlib/notifications/NotificationsBase.cs 69.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tevoinea tevoinea merged commit 8bd2d40 into microsoft:main Apr 4, 2023
This was referenced Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants