This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Cap recursion in ORM #2992
Merged
tevoinea
merged 16 commits into
microsoft:main
from
tevoinea:tevoinea/CapRecursionInORM
Apr 12, 2023
Merged
Cap recursion in ORM #2992
tevoinea
merged 16 commits into
microsoft:main
from
tevoinea:tevoinea/CapRecursionInORM
Apr 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2992 +/- ##
==========================================
+ Coverage 29.02% 29.07% +0.04%
==========================================
Files 304 304
Lines 36326 36360 +34
==========================================
+ Hits 10545 10570 +25
- Misses 25781 25790 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chkeita
reviewed
Apr 7, 2023
chkeita
approved these changes
Apr 10, 2023
Porges
reviewed
Apr 10, 2023
Porges
reviewed
Apr 10, 2023
Porges
reviewed
Apr 10, 2023
Porges
suggested changes
Apr 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small typos to fix
Porges
approved these changes
Apr 12, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
Closes #2900
Closes #2901
Closes #2902
#2900
Considers 2 new cases in our Entity Conversion code:
In both cases, we throw a new
OrmShortCircuitInfiniteLoopException
and stop deserialization.#2901 & #2902
LogTracer
to theEntityConverter
Validation Steps Performed
How does someone test & validate?
Added a test that demonstrates the issue where the discriminator field
EventType
is self referential.I looked through our codebase and didn't find any situation where we have this self referential situation but it's possible for the issue to be coming from entities in our database -- which would be much harder to check for this self referential behavior. Though, if/when this issue happens again, because of the improved logging changes, we should be able to track down the offending etities.