This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Add custom domain cert KeyVault access policy to deployment #3004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deleted after merge from origin/main
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
TEST
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Fork Sync: Update from parent repository
Codecov Report
@@ Coverage Diff @@
## main #3004 +/- ##
==========================================
+ Coverage 29.02% 29.61% +0.58%
==========================================
Files 304 273 -31
Lines 36326 30697 -5629
==========================================
- Hits 10545 9091 -1454
+ Misses 25781 21606 -4175 see 51 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chkeita
approved these changes
Apr 10, 2023
AdamL-Microsoft
added a commit
that referenced
this pull request
Apr 10, 2023
AdamL-Microsoft
deleted the
add-custom-domain-cert-keyvault-access-policy-to-deployment
branch
This was referenced Apr 11, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Add the required KeyVault access policy to allow the OneFuzz Function App to retrieve an SSL cert securing the custom domain's endpoint.
Fixes #2954
PR Checklist
Info on Pull Request
updated:
src/deployment/azuredeploy.bicep