Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Use insta crate for snapshot tests of stacktrace parsing #3027

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Conversation

Porges
Copy link
Member

@Porges Porges commented Apr 17, 2023

This makes it easier to regenerate the tests, and also provides nice diffs when things go wrong.

The only changes to current output files is the addition of a header. I've also enabled some more inputs where we already had checked-in outputs but the inputs were currently disabled for some reason.

I noticed some problems in some of the parsed outputs so there are a few bugs to fix in the stacktrace parser.

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Merging #3027 (ef65ecf) into main (03e5eff) will increase coverage by 0.00%.
The diff coverage is 89.83%.

@@           Coverage Diff           @@
##             main    #3027   +/-   ##
=======================================
  Coverage   29.42%   29.43%           
=======================================
  Files         305      305           
  Lines       36550    36544    -6     
=======================================
  Hits        10755    10755           
+ Misses      25795    25789    -6     
Impacted Files Coverage Δ
src/agent/stacktrace-parser/src/lib.rs 90.33% <89.83%> (+1.39%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Base automatically changed from dotnet-exception-parsing to main April 17, 2023 22:50
@Porges Porges marked this pull request as ready for review April 17, 2023 23:16
@Porges Porges changed the title Use insta for snapshot tests of stacktrace parsing Use insta crate for snapshot tests of stacktrace parsing Apr 18, 2023
@Porges Porges enabled auto-merge (squash) April 18, 2023 01:17
@Porges Porges merged commit bd2b109 into main Apr 18, 2023
@Porges Porges deleted the use-insta branch April 18, 2023 20:09
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants