This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Add more context to the deletion of nodes #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tevoinea
reviewed
May 12, 2023
tevoinea
approved these changes
May 12, 2023
Codecov Report
@@ Coverage Diff @@
## main #3102 +/- ##
=======================================
Coverage 31.82% 31.82%
=======================================
Files 307 307
Lines 36778 36779 +1
=======================================
+ Hits 11703 11704 +1
Misses 25075 25075
|
Co-authored-by: Teo Voinea <58236992+tevoinea@users.noreply.github.com>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Add a reason when deleting nodes. This will help us understand circumstances that lead to task being stopped while running